Added snapping when scrolling the schedule on homepage. #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 16. |
|
closing because we can handle this in a better way. Will update the ticket to address this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented snapping when scrolling on the schedule. The the rows are snapped on top and the columns are snapped to the end.
screen-capture.2.webm
The vertical scrolling works as expected, but there's still some weird behavior for horizontal scroll. The scroll sometimes get snapped to a portion in the middle of a cell instead of to the end. I will try to investigate the docs for scroll-snap-align more thoroughly in the future to see why.
screen-capture (3).webm
Some weird behavior with horizontal snapping
This pull request is the first step towards redesigning the schedule on the home page.
Test Plan
I tested the scrolling on different screen sizes and it doesn't work too well on smaller screens like the Iphone, so I might have to do a media queries in the future.